On Mon, Aug 23, 2021 at 02:52:21PM +0300, Leon Romanovsky wrote: > +RDMA > > Jakub, David > > Can we please ask that everything directly or indirectly related to RDMA > will be sent to linux-rdma@ too? > > On Sun, Aug 22, 2021 at 09:54:48PM +0300, Shai Malin wrote: > > Enable the RoCE and iWARP FW relaxed ordering. > > > > Signed-off-by: Ariel Elior <aelior@xxxxxxxxxxx> > > Signed-off-by: Shai Malin <smalin@xxxxxxxxxxx> > > drivers/net/ethernet/qlogic/qed/qed_rdma.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/drivers/net/ethernet/qlogic/qed/qed_rdma.c b/drivers/net/ethernet/qlogic/qed/qed_rdma.c > > index 4f4b79250a2b..496092655f26 100644 > > +++ b/drivers/net/ethernet/qlogic/qed/qed_rdma.c > > @@ -643,6 +643,8 @@ static int qed_rdma_start_fw(struct qed_hwfn *p_hwfn, > > cnq_id); > > } > > > > + p_params_header->relaxed_ordering = 1; > > Maybe it is only description that needs to be updated, but I would > expect to see call to pcie_relaxed_ordering_enabled() before setting > relaxed_ordering to always true. > > If we are talking about RDMA, the IB_ACCESS_RELAXED_ORDERING flag should > be taken into account too. Why does this file even exist in netdev? This whole struct qed_rdma_ops mess looks like another mis-design to support out of tree modules?? Jason
