Re: [PATCH for-next] qedr: Move variables reset to qedr_set_common_qp_params()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Dear Jason,

On Wed, Aug 11, 2021 at 5:15 PM Jason Gunthorpe <jgg@xxxxxxxxxx> wrote:
>
> On Wed, Aug 11, 2021 at 08:16:50AM +0300, Prabhakar Kushwaha wrote:
> > Qedr code is tightly coupled with existing both INIT transitions.
> > Here, during first INIT transition all variables are reset and
> > the RESET state is checked in post_recv() before any posting.
> >
> > Commit dc70f7c3ed34 ("RDMA/cma: Remove unnecessary INIT->INIT
> > transition") exposed this bug.
>
>
> Since we are reverting this the patch still makse sense? Certainly
> having a driver depend on two init->init transitions seems wrong to me
>

Yes, definitely still makes sense, thanks.

-- prabhakar (pk)



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux