Re: [PATCH rdma-core] irdma: Restore full memory barrier for doorbell optimization

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH rdma-core] irdma: Restore full memory barrier for doorbell optimization
From: Jason Gunthorpe <jgg@xxxxxxxxxx>
Date: Tue, 10 Aug 2021 08:59:33 -0300
Cc: "dledford@xxxxxxxxxx" <dledford@xxxxxxxxxx>, "leon@xxxxxxxxxx" <leon@xxxxxxxxxx>, "linux-rdma@xxxxxxxxxxxxxxx" <linux-rdma@xxxxxxxxxxxxxxx>
In-reply-to: <DM6PR11MB4692155E49A76F8789881338CBF69@DM6PR11MB4692.namprd11.prod.outlook.com>
References: <20210805161134.1234-1-tatyana.e.nikolova@intel.com> <20210806012853.GP1721383@nvidia.com> <DM6PR11MB4692155E49A76F8789881338CBF69@DM6PR11MB4692.namprd11.prod.outlook.com>

On Mon, Aug 09, 2021 at 08:07:32PM +0000, Nikolova, Tatyana E wrote:
> 1.	Software writing the valid bit in the WQE.
> 2.	Software reading shadow memory (hw_tail) value.

You are missing an ordered atomic on this read it looks like

Jason

Follow-Ups:
- [PATCH rdma-core] irdma: Restore full memory barrier for doorbell optimization
  - From: Tatyana Nikolova

References:
- [PATCH rdma-core] irdma: Restore full memory barrier for doorbell optimization
  - From: Tatyana Nikolova
- Re: [PATCH rdma-core] irdma: Restore full memory barrier for doorbell optimization
  - From: Jason Gunthorpe
- RE: [PATCH rdma-core] irdma: Restore full memory barrier for doorbell optimization
  - From: Nikolova, Tatyana E

Prev by Date: [PATCH v2 net] net: switchdev: zero-initialize struct switchdev_notifier_fdb_info emitted by drivers towards the bridge
Next by Date: Re: [PATCH v2 net] net: switchdev: zero-initialize struct switchdev_notifier_fdb_info emitted by drivers towards the bridge
Previous by thread: RE: [PATCH rdma-core] irdma: Restore full memory barrier for doorbell optimization
Next by thread: [PATCH rdma-core] irdma: Restore full memory barrier for doorbell optimization
Index(es):
- Date
- Thread

[Index of Archives] [Linux USB Devel] [Video for Linux] [Linux Audio Users] [Photo] [Yosemite News] [Yosemite Photos] [Linux Kernel] [Linux SCSI] [XFree86]