Re: [PATCH for-next 09/10] RDMA/rtrs: Add support to disable an IB port on the storage side

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Aug 02, 2021 at 07:43:05PM +0200, Haris Iqbal wrote:
> On Mon, Aug 2, 2021 at 6:36 PM Leon Romanovsky <leon@xxxxxxxxxx> wrote:
> >
> > On Mon, Aug 02, 2021 at 04:31:01PM +0200, Haris Iqbal wrote:
> > > On Mon, Aug 2, 2021 at 9:30 AM Leon Romanovsky <leon@xxxxxxxxxx> wrote:
> > > >
> > > > On Fri, Jul 30, 2021 at 03:18:31PM +0200, Jack Wang wrote:
> > > > > From: Md Haris Iqbal <haris.iqbal@xxxxxxxxxxxxxxx>
> > > > >
> > > > > This commit adds support to reject connection on a specific IB port which
> > > > > can be specified in the added sysfs entry for the rtrs-server module.
> > > > >
> > > > > Example,
> > > > >
> > > > > $ echo "mlx4_0 1" > /sys/class/rtrs-server/ctl/disable_port
> > > > >
> > > > > When a connection request is received on the above IB port, rtrs_srv
> > > > > rejects the connection and notifies the client to disable reconnection
> > > > > attempts. A manual reconnect has to be triggerred in such a case.
> > > > >
> > > > > A manual reconnect can be triggered by doing the following,
> > > > >
> > > > > echo 1 > /sys/class/rtrs-client/blya/paths/<select-path>/reconnect
> >
> > <...>
> >
> > > >
> > > > And maybe Jason thinks differently, but I don't feel comfortable with
> > > > such new sysfs file at all.
> >
> > This part is much more important and should be cleared before resending.
> 
> Agreed. I will wait for Jason to respond.

Based on some past conversation with Greg I'm skeptical he would
approve of this kind of usage of sysfs..

It is also very strange that this is under a class directory, I'm
starting to think it was a mistake to merge the original sysfs stuff
:(

Can you do this some other way?

Jason



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux