Re: [PATCH v3 0/1] RDMA/rxe: Bump up default maximum values used via uverbs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Bob,

Your third patch has an issue.

In rxe_cq_post()


addr = producer_addr(cq->queue, QUEUE_TYPE_TO_CLIENT);

It should be

addr = producer_addr(cq->queue, QUEUE_TYPE_FROM_CLIENT);

After making this change, I have tested my patch and rping works.

Bob can you please point me to the discussion which lead to the current changes, particularly the need for user barrier.

Zhu can you apply Bob's 3 patches + the change above + my patch and report back. In my testing it works.

Regards,

Shoaib

On 7/29/21 4:08 PM, Pearson, Robert B wrote:
I found another rxe bug (for SRQ) and sent three bug fixes in a set including the one you mention. They should all be applied.

-----Original Message-----
From: Jason Gunthorpe <jgg@xxxxxxxx>
Sent: Thursday, July 29, 2021 2:51 PM
To: Shoaib Rao <rao.shoaib@xxxxxxxxxx>
Cc: Zhu Yanjun <zyjzyj2000@xxxxxxxxx>; RDMA mailing list <linux-rdma@xxxxxxxxxxxxxxx>
Subject: Re: [PATCH v3 0/1] RDMA/rxe: Bump up default maximum values used via uverbs

On Thu, Jul 29, 2021 at 12:33:14PM -0700, Shoaib Rao wrote:

Can we please accept my initial patch where I bumped up the values of
a few parameters. We have extensively tested with those values. I will
try to resolve CRC errors and panic and make changes to other tuneables later?
I think Bob posted something for the icrc issues already

Please try to work in a sane fashion, rxe shouldn't be left broken with so many people apparently interested in it??

Jason



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux