Re: [PATCH for-next 06/10] RDMA/rtrs: Remove len parameter from helper print functions of sysfs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Aug 2, 2021 at 9:09 AM Leon Romanovsky <leon@xxxxxxxxxx> wrote:
>
> On Fri, Jul 30, 2021 at 03:18:28PM +0200, Jack Wang wrote:
> > From: Md Haris Iqbal <haris.iqbal@xxxxxxxxx>
> >
> > Since we have changed all sysfs show functions to use sysfs_emit, we do
> > not require the len (PAGE_SIZE) in our helper print functions. So remove
> > it from the function parameter.
> >
> > Signed-off-by: Md Haris Iqbal <haris.iqbal@xxxxxxxxx>
> > Signed-off-by: Jack Wang <jinpu.wang@xxxxxxxxx>
> > ---
> >  drivers/infiniband/ulp/rtrs/rtrs-clt-stats.c | 12 ++++--------
> >  drivers/infiniband/ulp/rtrs/rtrs-clt.h       | 12 +++++-------
> >  drivers/infiniband/ulp/rtrs/rtrs-pri.h       |  2 +-
> >  drivers/infiniband/ulp/rtrs/rtrs-srv-stats.c |  3 +--
> >  drivers/infiniband/ulp/rtrs/rtrs-srv.h       |  3 +--
> >  5 files changed, 12 insertions(+), 20 deletions(-)
>
> I suggest to squash this patch to the one mentioned in the commit message.

The purpose of the 2 patches are different. I would prefer keeping
them separate; unless there is a clear and obvious reason NOT to do
so.

Thanks

>
> Thanks



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux