On Fri, Jul 30, 2021 at 03:18:29PM +0200, Jack Wang wrote: > From: Gioh Kim <gi-oh.kim@xxxxxxxxx> > > The IO performance test with fio after swapping the likely > and unlikely macros in all if-statement shows no difference. > They do not help for the performance of rtrs. > > Thanks to Haakon Bugge for the test scenario. > > The fio test did random read on 32 rnbd devices and 64 processes. > Test environment: > - Intel(R) Xeon(R) Gold 6130 CPU @ 2.10GHz > - 376G memory > - kernel version: 5.4.86 > - gcc version: gcc (Debian 8.3.0-6) 8.3.0 > - Infiniband controller: Mellanox Technologies MT27800 Family > [ConnectX-5] > > Test result: > - before swapping: IOPS=829k, BW=3239MiB/s > - after swapping: IOPS=829k, BW=3238MiB/s > - remove all (un)likely: IOPS=829k, BW=3238MiB/s > > Signed-off-by: Gioh Kim <gi-oh.kim@xxxxxxxxx> > Signed-off-by: Jack Wang <jinpu.wang@xxxxxxxxx> > --- > drivers/infiniband/ulp/rtrs/rtrs-clt-stats.c | 2 +- > drivers/infiniband/ulp/rtrs/rtrs-clt.c | 126 +++++++++---------- > drivers/infiniband/ulp/rtrs/rtrs-srv.c | 74 ++++++----- > 3 files changed, 99 insertions(+), 103 deletions(-) > Thanks a lot, Reviewed-by: Leon Romanovsky <leonro@xxxxxxxxxx>