On Wed, Jul 28, 2021 at 01:50:48PM +0000, Marciniszyn, Mike wrote: > > > > > > commit dc70f7c3ed34b081c02a611591c5079c53b771b8 > > > Author: H kon Bugge <haakon.bugge@xxxxxxxxxx> > > > Date: Tue Jun 22 15:39:56 2021 +0200 > > > > > > RDMA/cma: Remove unnecessary INIT->INIT transition > > > > > > In rdma_create_qp(), a connected QP will be transitioned to the INIT > > > state. > > > > > > Afterwards, the QP will be transitioned to the RTR state by the > > > cma_modify_qp_rtr() function. But this function starts by performing an > > > ib_modify_qp() to the INIT state again, before another ib_modify_qp() is > > > performed to transition the QP to the RTR state. > > > > > > Hence, there is no need to transition the QP to the INIT state in > > > rdma_create_qp(). > > > > > > Link: https://lore.kernel.org/r/1624369197-24578-2-git-send-email- > > > haakon.bugge@xxxxxxxxxx > > > Signed-off-by: H kon Bugge <haakon.bugge@xxxxxxxxxx> > > > Reviewed-by: Leon Romanovsky <leonro@xxxxxxxxxx> > > > Signed-off-by: Jason Gunthorpe <jgg@xxxxxxxxxx> > > > > A brief unit test with the patch reverted in 5.14-rc3 shows that this patch may > > be responsible for iSer CI regressions there as well. > > A test of 5.15-rc3 + a revert tested clean. > > Jason, do you need a patch to revert or should I send one. Please, I would like to hear from Haakon as well Jason
