Re: [PATCH net-next v3 27/31] dev_ioctl: split out ndo_eth_ioctl

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jul 27, 2021 at 03:45:13PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@xxxxxxxx>
> 
> Most users of ndo_do_ioctl are ethernet drivers that implement
> the MII commands SIOCGMIIPHY/SIOCGMIIREG/SIOCSMIIREG, or hardware
> timestamping with SIOCSHWTSTAMP/SIOCGHWTSTAMP.
> 
> Separate these from the few drivers that use ndo_do_ioctl to
> implement SIOCBOND, SIOCBR and SIOCWANDEV commands.
> 
> This is a purely cosmetic change intended to help readers find
> their way through the implementation.
> 
> Cc: Doug Ledford <dledford@xxxxxxxxxx>
> Cc: Jason Gunthorpe <jgg@xxxxxxxx>
> Cc: Jay Vosburgh <j.vosburgh@xxxxxxxxx>
> Cc: Veaceslav Falico <vfalico@xxxxxxxxx>
> Cc: Andy Gospodarek <andy@xxxxxxxxxxxxx>
> Cc: Andrew Lunn <andrew@xxxxxxx>
> Cc: Vivien Didelot <vivien.didelot@xxxxxxxxx>
> Cc: Florian Fainelli <f.fainelli@xxxxxxxxx>
> Cc: Vladimir Oltean <olteanv@xxxxxxxxx>
> Cc: Leon Romanovsky <leon@xxxxxxxxxx>
> Cc: linux-rdma@xxxxxxxxxxxxxxx
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
>  Documentation/networking/netdevices.rst       |  4 ++
>  Documentation/networking/timestamping.rst     |  6 +--
>  drivers/infiniband/ulp/ipoib/ipoib_main.c     |  8 ++--

Acked-by: Jason Gunthorpe <jgg@xxxxxxxxxx>

ipoib is a convoluted, but this transform looks OK

Jason



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux