On Thu, Jul 22, 2021 at 03:59:04PM +0800, Wenpeng Liang wrote: > > > On 2021/7/18 20:00, Leon Romanovsky wrote: > > From: Leon Romanovsky <leonro@xxxxxxxxxx> > > > > Convert QP object to follow IB/core general allocation scheme. > > That change allows us to make sure that restrack properly kref > > the memory. > > > > Signed-off-by: Leon Romanovsky <leonro@xxxxxxxxxx> > > Hi, Leon, I tested your patchset, it looks good to hns. > But there is a redundant assignment in hns. > This is the patch. Thanks a lot. > > diff --git a/drivers/infiniband/hw/hns/hns_roce_qp.c b/drivers/infiniband/hw/hns/hns_roce_qp.c > index 364f404..fd0f71a 100644 > --- a/drivers/infiniband/hw/hns/hns_roce_qp.c > +++ b/drivers/infiniband/hw/hns/hns_roce_qp.c > @@ -959,8 +959,6 @@ static int set_qp_param(struct hns_roce_dev *hr_dev, struct hns_roce_qp *hr_qp, > struct ib_device *ibdev = &hr_dev->ib_dev; > int ret; > > - hr_qp->ibqp.qp_type = init_attr->qp_type; > - > if (init_attr->cap.max_inline_data > hr_dev->caps.max_sq_inline) > init_attr->cap.max_inline_data = hr_dev->caps.max_sq_inline;
