On 7/20/2021 3:27 PM, Leon Romanovsky wrote:
On Tue, Jul 20, 2021 at 12:27:46PM +0300, Yishai Hadas wrote:
On 7/20/2021 11:51 AM, Leon Romanovsky wrote:
On Tue, Jul 20, 2021 at 11:16:23AM +0300, Yishai Hadas wrote:
From: Maor Gottlieb <maorg@xxxxxxxxxx>
Usage will be in next patches.
Signed-off-by: Maor Gottlieb <maorg@xxxxxxxxxx>
Signed-off-by: Yishai Hadas <yishaih@xxxxxxxxxx>
---
providers/mlx5/mlx5.c | 28 ++++++++++++++--------------
providers/mlx5/mlx5.h | 4 ++++
2 files changed, 18 insertions(+), 14 deletions(-)
Probably, this patch will be needed to be changed after
"Verbs logging API" PR https://github.com/linux-rdma/rdma-core/pull/1030
Thanks
Well, not really, this patch just reorganizes things inside mlx5 for code
sharing.
After Gal's PR, I expect to see all mlx5 file/debug logic gone except
some minimal conversion logic to support old legacy variables.
All that get_env_... code will go.
Thanks
Looking on current VERBs logging PR, it doesn't give a clean path
conversion from mlx5.
For example it missed a debug granularity per object (e.g. QP, CQ, etc.)
, in addition it doesn't define a driver specific options as we have
today in mlx5 (e.g. MLX5_DBG_DR).
I believe that this should be added before going forward with the
logging PR to enable a clean transition later on.
The transition of mlx5 should preserve current API/semantics (ENV, etc.)
and is an orthogonal task.
Yishai
