On 7/19/21 12:10 PM, Jason Gunthorpe wrote: > On Mon, Jul 19, 2021 at 11:53:20AM -0400, Olga Kornievskaia wrote: >> On Mon, Jul 19, 2021 at 5:16 AM Zhu Yanjun <zyjzyj2000@xxxxxxxxx> wrote: >>> >>> On Sat, Jul 17, 2021 at 1:38 AM Jason Gunthorpe <jgg@xxxxxxxxxx> wrote: >>>> >>>> On Tue, Jul 06, 2021 at 11:00:32PM -0500, Bob Pearson wrote: >>>>> This series of patches is a cleanup of the ICRC code in the rxe driver. >>>>> The end result is to collect all the ICRC focused code into rxe_icrc.c >>>>> with three APIs that are used by the rest of the driver. One to initialize >>>>> the crypto engine used to compute crc32, and one each to generate and >>>>> check the ICRC in a packet. >>>>> >>>>> Signed-off-by: Bob Pearson <rpearsonhpe@xxxxxxxxx> >>>>> v2: >>>>> Split up the 5 patches in the first version into 9 patches which are >>>>> each focused on a single change. >>>>> Fixed sparse warnings in the first version. >>>>> >>>>> Bob Pearson (9): >>>>> RDMA/rxe: Move ICRC checking to a subroutine >>>>> RDMA/rxe: Move rxe_xmit_packet to a subroutine >>>>> RDMA/rxe: Fixup rxe_send and rxe_loopback >>>>> RDMA/rxe: Move ICRC generation to a subroutine >>>>> RDMA/rxe: Move rxe_crc32 to a subroutine >>>>> RDMA/rxe: Fixup rxe_icrc_hdr >>>>> RDMA/rxe: Move crc32 init code to rxe_icrc.c >>>>> RDMA/rxe: Add kernel-doc comments to rxe_icrc.c >>>>> RDMA/rxe: Fix types in rxe_icrc.c >>>> >>>> Applied to for-next, thanks >>> >>> Hi, Jason && Bob >>> >>> I confronted a problem. >>> One hosts with this patch series, A >>> other hosts, without this patch series, B >>> >>> I run rping between A <-------> B. >>> >>> I confronted the following errors, and rping can not succeed. >>> " >>> ... >>> [ 1848.251273] rdma_rxe: bad ICRC from 172.16.1.61 >>> [ 1971.750691] rdma_rxe: bad ICRC from 172.16.1.61 >>> ... >>> " >>> It seems that this patch series breaks the Backward compatibility of RXE. >>> >>> Not sure if it is a problem. Please comment. >>> >>> Thanks a lot. >>> Zhu Yanjun >> >> I would like to second this post. I was about to submit a new post >> asking about why rxe isn't working and if it's known. I'm trying to >> figure out when/what patch broke things. From the stand point of >> NFSoRDMA, it stopped working and I have discovered that simple rping >> doesn't work as well. The last known working release was 5.11. > > This isn't included in v5.13 or v5.14, so it can't be this series > > You should send Bob and Zhu your non-working report > > Jason > I'm working on finding what went wrong for Zhu. SHould have something in the next couple of hours. Bob
