On 18/07/2021 15:00, Leon Romanovsky wrote:
> From: Leon Romanovsky <leonro@xxxxxxxxxx>
>
> Convert QP object to follow IB/core general allocation scheme.
> That change allows us to make sure that restrack properly kref
> the memory.
>
> Signed-off-by: Leon Romanovsky <leonro@xxxxxxxxxx>
EFA and core parts look good to me.
Reviewed-by: Gal Pressman <galpress@xxxxxxxxxx>
Tested-by: Gal Pressman <galpress@xxxxxxxxxx>
> +static inline void *rdma_zalloc_obj(struct ib_device *dev, size_t size,
> + gfp_t gfp, bool is_numa_aware)
> +{
> + if (is_numa_aware && dev->ops.get_numa_node)
Honestly I think it's better to return an error if a numa aware allocation is
requested and get_numa_node is not provided.
> + return kzalloc_node(size, gfp, dev->ops.get_numa_node(dev));
> +
> + return kzalloc(size, gfp);
> +}
