On Tue, Jul 06, 2021 at 11:00:36PM -0500, Bob Pearson wrote: > +/* rxe_icrc_generate- compute ICRC for a packet. */ > +void rxe_icrc_generate(struct sk_buff *skb, struct rxe_pkt_info *pkt) > +{ > + __be32 *icrcp; > + u32 icrc; > + > + icrcp = (__be32 *)(pkt->hdr + pkt->paylen - RXE_ICRC_SIZE); > + icrc = rxe_icrc_hdr(pkt, skb); > + icrc = rxe_crc32(pkt->rxe, icrc, (u8 *)payload_addr(pkt), > + payload_size(pkt) + bth_pad(pkt)); > + *icrcp = (__force __be32)~icrc; > +} Same comment here, the u32 icrc should be a __be32 because that is what rxe_crc32 returns, no force Jason