On Wed, Jul 14, 2021 at 5:15 PM Leon Romanovsky <leon@xxxxxxxxxx> wrote: > > On Tue, Jul 13, 2021 at 11:11:28PM -0400, yanjun.zhu@xxxxxxxxx wrote: > > From: Zhu Yanjun <yanjun.zhu@xxxxxxxxx> > > > > The function irdma_sc_repost_aeq_entries always returns zero. So > > the returned type is changed to void. > > > > Signed-off-by: Zhu Yanjun <yanjun.zhu@xxxxxxxxx> > > --- > > drivers/infiniband/hw/irdma/ctrl.c | 4 +--- > > drivers/infiniband/hw/irdma/type.h | 3 +-- > > 2 files changed, 2 insertions(+), 5 deletions(-) > > <...> > > > -enum irdma_status_code irdma_sc_repost_aeq_entries(struct irdma_sc_dev *dev, > > - u32 count); > > I clearly remember that Jakub asked for more than once to remo remove > custom ice/irdma error codes. Did it happen? Can we get rid from them > in RDMA too? No. This is not related with custom ice/irdma error codes. This is related with the returned type of the function. If a function always returns 0, change the function returned type to void. And remove the related returned value check. Zhu Yanjun > > Thanks
