On 7/12/21 1:42 PM, Jason Gunthorpe wrote:
> On Tue, Jul 06, 2021 at 01:23:45PM -0400, Dennis Dalessandro wrote:
>> From: Mike Marciniszyn <mike.marciniszyn@xxxxxxxxxxxxxxxxxxxx>
>>
>> There is no counter for dmawait in AIP, which hampers debugging
>> performance issues.
>>
>> Add the counter increment when the txq is queued.
>>
>> Fixes: d99dc602e2a5 ("IB/hfi1: Add functions to transmit datagram ipoib packets")
>> Fixes: c4cf5688ea69 ("IB/hfi1: Indicate DMA wait when txq is queued for wakeup")
>
> Neither of these fixes lines are correct, please resend it with
> correct fixes lines.
I believe the thinking is these are fixes that should have had the counter in
the first place.
> This commit message is not quite good enough to justfy adding a
> counter increment to rc, can you explain how this is an existing
> counter and it is a bug that this single case was not incremented?
Yeah, agree. Fine to go to for-next instead.
I don't know why zero-day builds threw up on this commit. Seems unrelated.
-Denny
