On Wed, Jul 7, 2021 at 12:01 PM Bob Pearson <rpearsonhpe@xxxxxxxxx> wrote: > > This series of patches is a cleanup of the ICRC code in the rxe driver. > The end result is to collect all the ICRC focused code into rxe_icrc.c > with three APIs that are used by the rest of the driver. One to initialize > the crypto engine used to compute crc32, and one each to generate and > check the ICRC in a packet. > > Signed-off-by: Bob Pearson <rpearsonhpe@xxxxxxxxx> > --- > v2: > Split up the 5 patches in the first version into 9 patches which are > each focused on a single change. > Fixed sparse warnings in the first version. > > Bob Pearson (9): > RDMA/rxe: Move ICRC checking to a subroutine > RDMA/rxe: Move rxe_xmit_packet to a subroutine > RDMA/rxe: Fixup rxe_send and rxe_loopback > RDMA/rxe: Move ICRC generation to a subroutine > RDMA/rxe: Move rxe_crc32 to a subroutine > RDMA/rxe: Fixup rxe_icrc_hdr > RDMA/rxe: Move crc32 init code to rxe_icrc.c > RDMA/rxe: Add kernel-doc comments to rxe_icrc.c > RDMA/rxe: Fix types in rxe_icrc.c Thanks. It seems that these patches can pass rdma-core tests. I will delve into these patches soon. Zhu Yanjun > > drivers/infiniband/sw/rxe/rxe.h | 22 ----- > drivers/infiniband/sw/rxe/rxe_comp.c | 4 +- > drivers/infiniband/sw/rxe/rxe_icrc.c | 124 +++++++++++++++++++++++++- > drivers/infiniband/sw/rxe/rxe_loc.h | 61 +++---------- > drivers/infiniband/sw/rxe/rxe_mr.c | 22 +---- > drivers/infiniband/sw/rxe/rxe_net.c | 59 ++++++++++-- > drivers/infiniband/sw/rxe/rxe_recv.c | 23 +---- > drivers/infiniband/sw/rxe/rxe_req.c | 13 +-- > drivers/infiniband/sw/rxe/rxe_resp.c | 33 ++----- > drivers/infiniband/sw/rxe/rxe_verbs.c | 11 +-- > 10 files changed, 202 insertions(+), 170 deletions(-) > > -- > 2.30.2 >