> -----Original Message-----
> From: Majd Dibbiny <majd@xxxxxxxxxx>
> Sent: Wednesday, July 7, 2021 7:33 AM
> To: yanjun.zhu@xxxxxxxxx
> Cc: zyjzyj2000@xxxxxxxxx; Ismail, Mustafa <mustafa.ismail@xxxxxxxxx>;
> Saleem, Shiraz <shiraz.saleem@xxxxxxxxx>; dledford@xxxxxxxxxx;
> jgg@xxxxxxxx; linux-rdma@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH 1/1] RDMA/irdma: change the returned type to void
>
>
> > On 7 Jul 2021, at 17:24, yanjun.zhu@xxxxxxxxx wrote:
> >
> > From: Zhu Yanjun <yanjun.zhu@xxxxxxxxx>
> >
> > Since the function irdma_sc_parse_fpm_commit_buf always returns 0,
> > remove the returned value check and change the returned type to void.
> >
> > Fixes: 3f49d6842569 ("RDMA/irdma: Implement HW Admin Queue OPs")
> > Signed-off-by: Zhu Yanjun <yanjun.zhu@xxxxxxxxx>
> Reviewed-by: Majd Dibbiny <majd@xxxxxxxxxx>
> > ---
> > drivers/infiniband/hw/irdma/ctrl.c | 9 ++++-----
> > 1 file changed, 4 insertions(+), 5 deletions(-)
> >
> > diff --git a/drivers/infiniband/hw/irdma/ctrl.c
> > b/drivers/infiniband/hw/irdma/ctrl.c
> > index b1023a7d0bd1..c3880a85e255 100644
> > --- a/drivers/infiniband/hw/irdma/ctrl.c
> > +++ b/drivers/infiniband/hw/irdma/ctrl.c
> > @@ -2845,7 +2845,7 @@ static u64 irdma_sc_decode_fpm_commit(struct
> > irdma_sc_dev *dev, __le64 *buf,
> > * parses fpm commit info and copy base value
> > * of hmc objects in hmc_info
> > */
> > -static enum irdma_status_code
> > +static void
> > irdma_sc_parse_fpm_commit_buf(struct irdma_sc_dev *dev, __le64
> *buf,
> > struct irdma_hmc_obj_info *info, u32 *sd) { @@
> > -2915,7 +2915,6 @@ irdma_sc_parse_fpm_commit_buf(struct
> irdma_sc_dev *dev, __le64 *buf,
> > else
> > *sd = (u32)(size >> 21);
> >
> > - return 0;
> > }
> >
> > /**
> > @@ -4434,9 +4433,9 @@ static enum irdma_status_code
> irdma_sc_cfg_iw_fpm(struct irdma_sc_dev *dev,
> > ret_code = irdma_sc_commit_fpm_val(dev->cqp, 0, hmc_info-
> >hmc_fn_id,
> > &commit_fpm_mem, true, wait_type);
> > if (!ret_code)
> > - ret_code = irdma_sc_parse_fpm_commit_buf(dev, dev-
> >fpm_commit_buf,
> > - hmc_info->hmc_obj,
> > - &hmc_info->sd_table.sd_cnt);
> > + irdma_sc_parse_fpm_commit_buf(dev, dev->fpm_commit_buf,
> > + hmc_info->hmc_obj,
> > + &hmc_info->sd_table.sd_cnt);
> > print_hex_dump_debug("HMC: COMMIT FPM BUFFER",
> DUMP_PREFIX_OFFSET, 16,
> > 8, commit_fpm_mem.va, IRDMA_COMMIT_FPM_BUF_SIZE,
> > false);
> > --
> > 2.27.0
> >
Acked-by: Tatyana Nikolova <tatyana.e.nikolova@xxxxxxxxx>
