> On 2 Jul 2021, at 14:30, ice_yangxiao@xxxxxxx wrote: > > From: Xiao Yang <yangx.jy@xxxxxxxxxxx> > > Signed-off-by: Xiao Yang <yangx.jy@xxxxxxxxxxx> LGTM, Reviewed-by: Håkon Bugge <haakon.bugge@xxxxxxxxxx> Not related to the commit, but whilst reviewing, it looks to me as the second "goto err1" in rxe_mr_init_user() has a memleak because mr->map is not deallocated. Thxs, Håkon > > --- > drivers/infiniband/sw/rxe/rxe_mr.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/infiniband/sw/rxe/rxe_mr.c b/drivers/infiniband/sw/rxe/rxe_mr.c > index 6aabcb4de235..487cefc015b8 100644 > --- a/drivers/infiniband/sw/rxe/rxe_mr.c > +++ b/drivers/infiniband/sw/rxe/rxe_mr.c > @@ -122,7 +122,6 @@ int rxe_mr_init_user(struct rxe_pd *pd, u64 start, u64 length, u64 iova, > goto err1; > } > > - mr->umem = umem; > num_buf = ib_umem_num_pages(umem); > > rxe_mr_init(access, mr); > -- > 2.26.2 >
