On Fri, Jun 18, 2021 at 08:07:55AM +0200, Håkon Bugge wrote: > In rdma_create_qp(), a connected QP will be transitioned to the INIT > state. > > Afterwards, the QP will be transitioned to the RTR state by the > cma_modify_qp_rtr() function. But this function starts by performing > an ib_modify_qp() to the INIT state again, before another > ib_modify_qp() is performed to transition the QP to the RTR state. > > Hence, there is no need to transition the QP to the INIT state in > rdma_create_qp(). > > Signed-off-by: Håkon Bugge <haakon.bugge@xxxxxxxxxx> > > --- > > v1 -> v2: > * Fixed uninitialized ret variable as: > Reported-by: kernel test robot <lkp@xxxxxxxxx> > --- > drivers/infiniband/core/cma.c | 17 +---------------- > 1 file changed, 1 insertion(+), 16 deletions(-) > I reviewed v1, let's add this tag to v2 too. Reviewed-by: Leon Romanovsky <leonro@xxxxxxxxxx>
