On Mon, Jun 21, 2021 at 3:15 PM <ice_yangxiao@xxxxxxx> wrote:
>
> From: Xiao Yang <yangx.jy@xxxxxxxxxxx>
>
> rxe_mr_init_user() always returns the fixed -EINVAL when ib_umem_get()
> fails so it's hard for user to know which actual error happens in
> ib_umem_get(). For example, ib_umem_get() will return -EOPNOTSUPP
> when trying to pin pages on a DAX file.
>
> Return actual error as mlx4/mlx5 does.
>
> Signed-off-by: Xiao Yang <yangx.jy@xxxxxxxxxxx>
> ---
> drivers/infiniband/sw/rxe/rxe_mr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/infiniband/sw/rxe/rxe_mr.c b/drivers/infiniband/sw/rxe/rxe_mr.c
> index 9f63947bab12..fe2b7d223183 100644
> --- a/drivers/infiniband/sw/rxe/rxe_mr.c
> +++ b/drivers/infiniband/sw/rxe/rxe_mr.c
> @@ -135,7 +135,7 @@ int rxe_mr_init_user(struct rxe_pd *pd, u64 start, u64 length, u64 iova,
> if (IS_ERR(umem)) {
> pr_warn("err %d from rxe_umem_get\n",
> (int)PTR_ERR(umem));
> - err = -EINVAL;
> + err = PTR_ERR(umem);
Thanks. I am fine with this.
Zhu Yanjun
> goto err1;
> }
>
> --
> 2.26.2
>
