Re: [PATCHv2 for-next 4/5] RDMA/rtrs: Rename some variables to avoid confusion

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jun 11, 2021 at 02:10:33PM +0200, Jack Wang wrote:
> From: Guoqing Jiang <guoqing.jiang@xxxxxxxxxxxxxxx>
> 
> Those variables are passed to create_cq, create_qp, rtrs_iu_alloc and
> rtrs_iu_free, so these *_size means the num of unit. And cq_size also
> means number of cq element.
> 
> Also move the setting of cq_num to common path.
> 
> Signed-off-by: Guoqing Jiang <guoqing.jiang@xxxxxxxxxxxxxxx>
> Reviewed-by: Md Haris Iqbal <haris.iqbal@xxxxxxxxxxxxxxx>
> Signed-off-by: Jack Wang <jinpu.wang@xxxxxxxxxxxxxxx>
> ---
>  drivers/infiniband/ulp/rtrs/rtrs-clt.c | 18 +++++++++---------
>  drivers/infiniband/ulp/rtrs/rtrs-clt.h |  2 +-
>  drivers/infiniband/ulp/rtrs/rtrs-pri.h | 10 +++++-----
>  drivers/infiniband/ulp/rtrs/rtrs-srv.c |  7 +++----
>  drivers/infiniband/ulp/rtrs/rtrs.c     | 24 ++++++++++++------------
>  5 files changed, 30 insertions(+), 31 deletions(-)
> 

Commit message is worth to rewrite.

Thanks,
Reviewed-by: Leon Romanovsky <leonro@xxxxxxxxxx>



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux