> On 10 Jun 2021, at 17:34, Devesh Sharma <devesh.sharma@xxxxxxxxxxxx> wrote:
>
> On Thu, Jun 10, 2021 at 6:13 PM Haakon Bugge <haakon.bugge@xxxxxxxxxx> wrote:
>>
>>
>>
>>> On 10 Jun 2021, at 12:49, Devesh Sharma <devesh.sharma@xxxxxxxxxxxx> wrote:
>>>
>>> To commit ?? ("RDMA/bnxt_re: update ABI to pass wqe-mode to user space").
>>>
>>> Signed-off-by: Devesh Sharma <devesh.sharma@xxxxxxxxxxxx>
>>> ---
>>> kernel-headers/rdma/bnxt_re-abi.h | 5 ++++-
>>> 1 file changed, 4 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/kernel-headers/rdma/bnxt_re-abi.h b/kernel-headers/rdma/bnxt_re-abi.h
>>> index dc52e3cf..52205ed2 100644
>>> --- a/kernel-headers/rdma/bnxt_re-abi.h
>>> +++ b/kernel-headers/rdma/bnxt_re-abi.h
>>> @@ -49,7 +49,8 @@
>>> #define BNXT_RE_CHIP_ID0_CHIP_MET_SFT 0x18
>>>
>>> enum {
>>> - BNXT_RE_UCNTX_CMASK_HAVE_CCTX = 0x1ULL
>>> + BNXT_RE_UCNTX_CMASK_HAVE_CCTX = 0x1ULL,
>>> + BNXT_RE_UCNTX_CMASK_HAVE_MODE = 0x02ULL
>>
>> Please use a comma for the last enum as well, to avoid this line to be unnecessary modified when you add another entry.
> Good suggestion, since this patch is rather dependent on kernel patch.
> I would let this patch be unchanged.
I see. Remember this next time you add/modify enum in the kernel uapi then :-)
Håkon
>>
>>
>> Thxs, Håkon
>>
>>> };
>>>
>>> struct bnxt_re_uctx_resp {
>>> @@ -62,6 +63,8 @@ struct bnxt_re_uctx_resp {
>>> __aligned_u64 comp_mask;
>>> __u32 chip_id0;
>>> __u32 chip_id1;
>>> + __u32 mode;
>>> + __u32 rsvd1; /* padding */
>>> };
>>>
>>> /*
>>> --
>>> 2.25.1
>>>
>>
>
>
> --
> -Regards
> Devesh
