On Mon, Jun 07, 2021 at 04:16:37PM +0800, Zhu Yanjun wrote: > On Sat, Jun 5, 2021 at 7:07 AM Bob Pearson <rpearsonhpe@xxxxxxxxx> wrote: > > > > Currently the rdma_rxe driver attempts to protect atomic responder > > resources by taking a reference to the qp which is only freed when the > > resource is recycled for a new read or atomic operation. This means that > > in normal circumstances there is almost always an extra qp reference > > once an atomic operation has been executed which prevents cleaning up > > the qp and associated pd and cqs when the qp is destroyed. > > > > This patch removes the call to rxe_add_ref() in send_atomic_ack() and the > > call to rxe_drop_ref() in free_rd_atomic_resource(). If the qp is > > Not sure if it is a good way to fix this problem by removing the call > to rxe_add_ref. > Because taking a reference to the qp is to protect atomic responder resources. > > Removing rxe_add_ref is to decrease the protection of the atomic > responder resources. All those rxe_add_ref/rxe_drop_ref in RXE are horrid. It will be good to delete them all. Thanks
