On Wed, May 19, 2021 at 11:37:31AM +0300, Leon Romanovsky wrote: > From: Leon Romanovsky <leonro@xxxxxxxxxx> > > The mlx4 and mlx5 implemented differently the WQ input checks. > Instead of duplicating mlx4 logic in the mlx5, let's prepare > the input in the central place. > > The mlx5 implementation didn't check for validity of state input. > It is not real bug because our FW checked that, but still worth to fix. > > Fixes: f213c0527210 ("IB/uverbs: Add WQ support") > Reported-by: Jiapeng Chong <jiapeng.chong@xxxxxxxxxxxxxxxxx> > Signed-off-by: Leon Romanovsky <leonro@xxxxxxxxxx> > --- > Changelog: > v2: > * Extended commit message > v1: https://lore.kernel.org/lkml/0433d8013ed3a2ffdd145244651a5edb2afbd75b.1621342527.git.leonro@xxxxxxxxxx > * Removed IB_WQS_RESET state checks because it is zero and wq states > declared as u32, so can't be less than IB_WQS_RESET. > v0: https://lore.kernel.org/lkml/932f87b48c07278730c3c760b3a707d6a984b524.1621332736.git.leonro@xxxxxxxxxx > --- > drivers/infiniband/core/uverbs_cmd.c | 21 +++++++++++++++++++-- > drivers/infiniband/hw/mlx4/qp.c | 9 ++------- > drivers/infiniband/hw/mlx5/qp.c | 6 ++---- > 3 files changed, 23 insertions(+), 13 deletions(-) Applied to for-next, thanks Jason