Re: [PATCH for-next v3 0/3] Fix memory ordering errors in queues

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, May 29, 2021 at 4:30 AM Jason Gunthorpe <jgg@xxxxxxxxxx> wrote:
>
> On Thu, May 27, 2021 at 02:47:45PM -0500, Bob Pearson wrote:
> > These patches optimize the memory ordering in rxe_queue.h so
> > that user space and not kernel space indices are protected for loads
> > with smp_load_acquire() and stores with smp_store_release(). The
> > original implementation of this did not apply to all index references
> > which has recently caused test case errors traced to stale memory loads.
> > These patches fix those errors and also protect kernel indices from
> > malicious modification by user space.
>
> I didn't read it carefully, but I think this captures the basic
> solution

I made tests with rdma-core.

With or without changes of kernel-headers/rdma/rdma_user_rxe.h,
the previously mentioned 17 errors disappear.

So this patch series takes effect.

Zhu Yanjun

>
> Jason



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux