Re: [PATCH v3 -next] RDMA/srp: use DEVICE_ATTR_*() macro

[Bart Van Assche <bvanassche@xxxxxxx>]

On 5/28/21 5:57 AM, YueHaibing wrote:
> -static ssize_t show_id_ext(struct device *dev, struct device_attribute *attr,
> -			   char *buf)
> +static ssize_t id_ext_show(struct device *dev,
> +			   struct device_attribute *attr, char *buf)

Please make better use of horizontal space by moving "struct
device_attribute *attr," to the end of the previous line. This advice
probably also applies to other changes in this patch.

Thanks,

Bart.