Re: [PATCH net-next v2 4/7] ice: Implement iidc operations

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 28 May 2021 16:48:17 +0000 Nguyen, Anthony L wrote:
> On Fri, 2021-05-28 at 10:02 -0300, Jason Gunthorpe wrote:
> > > 
> > > defensive programming  
> 
> Will remove this.
>
> > > RDMA folks, are you okay with drivers inventing their own error
> > > codes?  
> > 
> > Not really, I was ignoring it because it looks like big part of their
> > netdev driver layer.  
> 
> We have looked into how we can eliminate/minimize the use of ice_status
> and our assessment is that this will take a decent amount of work. We
> are trying to get this done.

Sorry I don't speak managerese.

I asked you to stop using your own error codes multiple times, and 
now you're about to pollute another subsystem with the same problem.

Please fix.



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux