On Wed, May 19, 2021 at 02:29:57PM +0300, Gal Pressman wrote: > On 17/05/2021 19:47, Jason Gunthorpe wrote: > > +struct rdma_hw_stats *efa_alloc_hw_device_stats(struct ib_device *ibdev) > > +{ > > + /* > > + * It is probably a bug that efa reports its port stats as device > > + * stats > > + */ > > Hmm, yea this needs some work. > Most of these stats are in fact port stats, but others (admin commands, > keep-alive, allocation/creation error) are device stats. > > You can split them if you wish, or I can send a followup patch. I'm not sure I'd guess right, you'd probably better take it > Thanks, > Tested-by: Gal Pressman <galpress@xxxxxxxxxx> Thanks, Jason