On Mon, May 17, 2021 at 07:12:55PM +0200, Greg KH wrote:
> > +int ib_port_sysfs_create_groups(struct ib_device *ibdev, u32 port_num,
> > + const struct attribute_group **groups)
> > +{
> > + return sysfs_create_groups(&ibdev->port_data[port_num].sysfs->kobj,
> > + groups);
> > +}
> > +EXPORT_SYMBOL(ib_port_sysfs_create_groups);
>
> You are wrapping _GPL symbols here with a "convenience" function, please
> make these all EXPORT_SYMBOL_GPL() so I don't get nervous.
These functions get deleted in a following patch once everything can
be switched to ops->get_port_groups(), which provides even less
flexability for the driver to do things wrong.
The whole subsystem already uses !GPL export so it is very strange to
see a GPL symbol at all:
$ git grep EXPORT_SYMBOL\( drivers/infiniband/core/ | wc -l
310
$ git grep EXPORT_SYMBOL_GPL\( drivers/infiniband/core/ | wc -l
1
Anyhow, if it makes you happy I'll change it.
Jason
