Re: [PATCH rdma-rc] RDMA/siw: Release xarray entry

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



-----"Leon Romanovsky" <leon@xxxxxxxxxx> wrote: -----

>To: "Doug Ledford" <dledford@xxxxxxxxxx>, "Jason Gunthorpe"
><jgg@xxxxxxxxxx>
>From: "Leon Romanovsky" <leon@xxxxxxxxxx>
>Date: 05/09/2021 01:41PM
>Cc: "Leon Romanovsky" <leonro@xxxxxxxxxx>, "Bernard Metzler"
><bmt@xxxxxxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx,
>linux-rdma@xxxxxxxxxxxxxxx
>Subject: [EXTERNAL] [PATCH rdma-rc] RDMA/siw: Release xarray entry
>
>From: Leon Romanovsky <leonro@xxxxxxxxxx>
>
>The xarray entry is allocated in siw_qp_add(), but release was
>missed in case zero-sized SQ was discovered.
>
>Fixes: 661f385961f0 ("RDMA/siw: Fix handling of zero-sized Read and
>Receive Queues.")
>Signed-off-by: Leon Romanovsky <leonro@xxxxxxxxxx>
>---
> drivers/infiniband/sw/siw/siw_verbs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/infiniband/sw/siw/siw_verbs.c
>b/drivers/infiniband/sw/siw/siw_verbs.c
>index 917c8a919f38..3f175f220a22 100644
>--- a/drivers/infiniband/sw/siw/siw_verbs.c
>+++ b/drivers/infiniband/sw/siw/siw_verbs.c
>@@ -375,7 +375,7 @@ struct ib_qp *siw_create_qp(struct ib_pd *pd,
> 	else {
> 		/* Zero sized SQ is not supported */
> 		rv = -EINVAL;
>-		goto err_out;
>+		goto err_out_xa;
> 	}
> 	if (num_rqe)
> 		num_rqe = roundup_pow_of_two(num_rqe);
>-- 
>2.31.1
>
>
Thanks Leon!

Reviewed-by: Bernard Metzler <bmt@xxxxxxxxxxxxxx>





[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux