On 4/22/21 11:00 AM, Leon Romanovsky wrote:
On Thu, Apr 22, 2021 at 10:12:33AM -0700, Bart Van Assche wrote:
On 4/22/21 5:24 AM, Jason Gunthorpe wrote:
On Mon, Apr 19, 2021 at 01:02:34PM -0700, Bart Van Assche wrote:
On 4/18/21 11:36 PM, Marion et Christophe JAILLET wrote:
The list in To: is the one given by get_maintainer.pl. Usualy, I only
put the ML in Cc: I've run the script on the 2 patches of the serie
and merged the 2 lists. Everyone is in the To: of the cover letter
and of the 2 patches.
If Théo is "Tejun Heo" ( (maintainer:WORKQUEUE) ), he is already in
the To: line.
Linus wants to see a "Cc: ${maintainer}" tag in patches that he receives
from a maintainer and that modify another subsystem than the subsystem
maintained by that maintainer.
Really? Do you remember a lore link for this?
Last time I saw Linus mentioning this was a few months ago.
Unfortunately I cannot find that message anymore.
Generally I've been junking the CC lines (vs Andrew at the other
extreme that often has 10's of CC lines)
Most entries in the MAINTAINERS file have one to three email addresses
so I'm surprised to read that Cc-ing maintainer(s) could result in tens
of Cc lines?
git log mm/
commit 2b8305260fb37fc20e13f71e13073304d0a031c8
Author: Alexander Potapenko <glider@xxxxxxxxxx>
Date: Thu Feb 25 17:19:21 2021 -0800
kfence, kasan: make KFENCE compatible with KASAN
Make KFENCE compatible with KASAN. Currently this helps test KFENCE
itself, where KASAN can catch potential corruptions to KFENCE state, or
other corruptions that may be a result of freepointer corruptions in the
main allocators.
[akpm@xxxxxxxxxxxxxxxxxxxx: merge fixup]
[andreyknvl@xxxxxxxxxx: untag addresses for KFENCE]
Link: https://lkml.kernel.org/r/9dc196006921b191d25d10f6e611316db7da2efc.1611946152.git.andreyknvl@xxxxxxxxxx
Link: https://lkml.kernel.org/r/20201103175841.3495947-7-elver@xxxxxxxxxx
Signed-off-by: Marco Elver <elver@xxxxxxxxxx>
Signed-off-by: Alexander Potapenko <glider@xxxxxxxxxx>
Signed-off-by: Andrey Konovalov <andreyknvl@xxxxxxxxxx>
Reviewed-by: Dmitry Vyukov <dvyukov@xxxxxxxxxx>
Reviewed-by: Jann Horn <jannh@xxxxxxxxxx>
Co-developed-by: Marco Elver <elver@xxxxxxxxxx>
Cc: Andrey Konovalov <andreyknvl@xxxxxxxxxx>
Cc: Andrey Ryabinin <aryabinin@xxxxxxxxxxxxx>
Cc: Andy Lutomirski <luto@xxxxxxxxxx>
Cc: Borislav Petkov <bp@xxxxxxxxx>
Cc: Catalin Marinas <catalin.marinas@xxxxxxx>
Cc: Christopher Lameter <cl@xxxxxxxxx>
Cc: Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx>
Cc: David Rientjes <rientjes@xxxxxxxxxx>
Cc: Eric Dumazet <edumazet@xxxxxxxxxx>
Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
Cc: Hillf Danton <hdanton@xxxxxxxx>
Cc: "H. Peter Anvin" <hpa@xxxxxxxxx>
Cc: Ingo Molnar <mingo@xxxxxxxxxx>
Cc: Joern Engel <joern@xxxxxxxxxxxxxxx>
Cc: Jonathan Corbet <corbet@xxxxxxx>
Cc: Joonsoo Kim <iamjoonsoo.kim@xxxxxxx>
Cc: Kees Cook <keescook@xxxxxxxxxxxx>
Cc: Mark Rutland <mark.rutland@xxxxxxx>
Cc: Paul E. McKenney <paulmck@xxxxxxxxxx>
Cc: Pekka Enberg <penberg@xxxxxxxxxx>
Cc: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
Cc: SeongJae Park <sjpark@xxxxxxxxx>
Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
Cc: Vlastimil Babka <vbabka@xxxxxxx>
Cc: Will Deacon <will@xxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
Signed-off-by: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
But where does that Cc-list come from? If I extract that patch and run
the get_maintainer.pl script, the following output appears:
$ git format-patch -1 2b8305260fb37fc20e13f71e13073304d0a031c8
0001-kfence-kasan-make-KFENCE-compatible-with-KASAN.patch
$ scripts/get_maintainer.pl
0001-kfence-kasan-make-KFENCE-compatible-with-KASAN.patch
Alexander Potapenko <glider@xxxxxxxxxx> (maintainer:KFENCE)
Marco Elver <elver@xxxxxxxxxx> (maintainer:KFENCE)
Dmitry Vyukov <dvyukov@xxxxxxxxxx> (reviewer:KFENCE)
Andrey Ryabinin <ryabinin.a.a@xxxxxxxxx> (maintainer:KASAN)
Andrey Konovalov <andreyknvl@xxxxxxxxx> (reviewer:KASAN)
Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> (maintainer:MEMORY MANAGEMENT)
kasan-dev@xxxxxxxxxxxxxxxx (open list:KFENCE)
linux-kernel@xxxxxxxxxxxxxxx (open list)
linux-mm@xxxxxxxxx (open list:MEMORY MANAGEMENT)
Additionally, please note that in my email I was referring to the
MAINTAINERS file. I do not use the get_maintainers.pl script but instead
select the Cc-list manually based on what I find in the MAINTAINERS file.
Thanks,
Bart.
