On Fri, Apr 02, 2021 at 05:07:33PM +0800, Weihang Li wrote: > - roce_set_field(eqc->byte_40, HNS_ROCE_EQC_NXT_EQE_BA_L_M, > - HNS_ROCE_EQC_NXT_EQE_BA_L_S, eqe_ba[1] >> 12); > - > - roce_set_field(eqc->byte_44, HNS_ROCE_EQC_NXT_EQE_BA_H_M, > - HNS_ROCE_EQC_NXT_EQE_BA_H_S, eqe_ba[1] >> 44); > - > - roce_set_field(eqc->byte_44, HNS_ROCE_EQC_EQE_SIZE_M, > - HNS_ROCE_EQC_EQE_SIZE_S, > - eq->eqe_size == HNS_ROCE_V3_EQE_SIZE ? 1 : 0); > + hr_reg_write(eqc, EQC_EQ_ST, HNS_ROCE_V2_EQ_STATE_VALID); > + hr_reg_write(eqc, EQC_EQE_HOP_NUM, eq->hop_num); > + hr_reg_write(eqc, EQC_OVER_IGNORE, eq->over_ignore); > + hr_reg_write(eqc, EQC_COALESCE, eq->coalesce); This really is a lot better like this, isn't it? Jason
