On Tue, Apr 06, 2021 at 07:15:00PM -0500, Shiraz Saleem wrote:
> From: Mustafa Ismail <mustafa.ismail@xxxxxxxxx>
>
> Add ABI definitions for irdma.
>
> Signed-off-by: Mustafa Ismail <mustafa.ismail@xxxxxxxxx>
> Signed-off-by: Shiraz Saleem <shiraz.saleem@xxxxxxxxx>
> include/uapi/rdma/irdma-abi.h | 116 ++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 116 insertions(+)
> create mode 100644 include/uapi/rdma/irdma-abi.h
>
> diff --git a/include/uapi/rdma/irdma-abi.h b/include/uapi/rdma/irdma-abi.h
> new file mode 100644
> index 0000000..d994b0b
> +++ b/include/uapi/rdma/irdma-abi.h
> @@ -0,0 +1,116 @@
> +/* SPDX-License-Identifier: (GPL-2.0 WITH Linux-syscall-note) OR Linux-OpenIB) */
> +/*
> + * Copyright (c) 2006 - 2021 Intel Corporation. All rights reserved.
> + * Copyright (c) 2005 Topspin Communications. All rights reserved.
> + * Copyright (c) 2005 Cisco Systems. All rights reserved.
> + * Copyright (c) 2005 Open Grid Computing, Inc. All rights reserved.
> + */
> +
> +#ifndef IRDMA_ABI_H
> +#define IRDMA_ABI_H
> +
> +#include <linux/types.h>
> +
> +/* irdma must support legacy GEN_1 i40iw kernel
> + * and user-space whose last ABI ver is 5
> + */
> +#define IRDMA_ABI_VER 5
> +
> +enum irdma_memreg_type {
> + IW_MEMREG_TYPE_MEM = 0,
> + IW_MEMREG_TYPE_QP = 1,
> + IW_MEMREG_TYPE_CQ = 2,
> + IW_MEMREG_TYPE_RSVD = 3,
> + IW_MEMREG_TYPE_MW = 4,
> +};
> +
> +struct irdma_alloc_ucontext_req {
> + __u32 rsvd32;
> + __u8 userspace_ver;
> + __u8 rsvd8[3];
> +};
> +
> +struct irdma_alloc_ucontext_resp {
> + __u32 max_pds;
> + __u32 max_qps;
> + __u32 wq_size; /* size of the WQs (SQ+RQ) in the mmaped area */
> + __u8 kernel_ver;
> + __u8 rsvd[3];
So this reserved is to align and for compat with i40iw
> + __aligned_u64 feature_flags;
> + __aligned_u64 db_mmap_key;
> + __u32 max_hw_wq_frags;
> + __u32 max_hw_read_sges;
> + __u32 max_hw_inline;
> + __u32 max_hw_rq_quanta;
> + __u32 max_hw_wq_quanta;
> + __u32 min_hw_cq_size;
> + __u32 max_hw_cq_size;
> + __u32 rsvd1[7];
But what is this for?
> + __u16 max_hw_sq_chunk;
> + __u16 rsvd2[11];
And this?
Reserved should only be used for alignment reasons.
You saw the other explosive thread with Intel about this topic, right?
> +struct irdma_mem_reg_req {
> + __u16 reg_type; /* Memory, QP or CQ */
Comment is better to clarify this is an enum irdma_memreg_type,
especially since it seems to be wrong?
Why is that enum prefixed with IW_?
Jason
