Re: [PATCH 2/4] RDMA/rtrs-clt: new sysfs attribute to print the latency of each path

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Apr 6, 2021 at 2:06 PM Gioh Kim <gi-oh.kim@xxxxxxxxx> wrote:
>
> From: Gioh Kim <gi-oh.kim@xxxxxxxxxxxxxxx>
>
> It shows the latest latency that the client checked when sending
> the heart-beat.
>
> Signed-off-by: Gioh Kim <gi-oh.kim@xxxxxxxxx>
> Signed-off-by: Jack Wang <jinpu.wang@xxxxxxxxx>
> ---
>  drivers/infiniband/ulp/rtrs/rtrs-clt-sysfs.c | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
>
> diff --git a/drivers/infiniband/ulp/rtrs/rtrs-clt-sysfs.c b/drivers/infiniband/ulp/rtrs/rtrs-clt-sysfs.c
> index bc46b7a99ba0..fc6de514b328 100644
> --- a/drivers/infiniband/ulp/rtrs/rtrs-clt-sysfs.c
> +++ b/drivers/infiniband/ulp/rtrs/rtrs-clt-sysfs.c
> @@ -354,6 +354,21 @@ static ssize_t rtrs_clt_hca_name_show(struct kobject *kobj,
>  static struct kobj_attribute rtrs_clt_hca_name_attr =
>         __ATTR(hca_name, 0444, rtrs_clt_hca_name_show, NULL);
>
> +static ssize_t rtrs_clt_cur_latency_show(struct kobject *kobj,
> +                                   struct kobj_attribute *attr,
> +                                   char *page)
> +{
> +       struct rtrs_clt_sess *sess;
> +
> +       sess = container_of(kobj, struct rtrs_clt_sess, kobj);
> +
> +       return scnprintf(page, PAGE_SIZE, "%lld ns\n",
> +                        ktime_to_ns(sess->s.hb_cur_latency));
> +}
sysfs_emit should be used like other functions in the same file.  Gioh
can you please fix it?

Thanks!
> +
> +static struct kobj_attribute rtrs_clt_cur_latency_attr =
> +       __ATTR(cur_latency, 0444, rtrs_clt_cur_latency_show, NULL);
> +
>  static ssize_t rtrs_clt_src_addr_show(struct kobject *kobj,
>                                        struct kobj_attribute *attr,
>                                        char *page)
> @@ -397,6 +412,7 @@ static struct attribute *rtrs_clt_sess_attrs[] = {
>         &rtrs_clt_reconnect_attr.attr,
>         &rtrs_clt_disconnect_attr.attr,
>         &rtrs_clt_remove_path_attr.attr,
> +       &rtrs_clt_cur_latency_attr.attr,
>         NULL,
>  };
>
> --
> 2.25.1
>



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux