From: Gioh Kim <gi-oh.kim@xxxxxxxxxxxxxxx> Two error messages are only different message but have common code to generate the path string. Signed-off-by: Gioh Kim <gi-oh.kim@xxxxxxxxx> Signed-off-by: Jack Wang <jinpu.wang@xxxxxxxxx> --- drivers/infiniband/ulp/rtrs/rtrs-clt.c | 23 +++++++---------------- 1 file changed, 7 insertions(+), 16 deletions(-) diff --git a/drivers/infiniband/ulp/rtrs/rtrs-clt.c b/drivers/infiniband/ulp/rtrs/rtrs-clt.c index a534b2b09e13..4369e4cf13f0 100644 --- a/drivers/infiniband/ulp/rtrs/rtrs-clt.c +++ b/drivers/infiniband/ulp/rtrs/rtrs-clt.c @@ -2462,32 +2462,23 @@ static int rtrs_send_sess_info(struct rtrs_clt_sess *sess) static int init_sess(struct rtrs_clt_sess *sess) { int err; + char str[NAME_MAX]; + struct rtrs_addr path = { + .src = &sess->s.src_addr, + .dst = &sess->s.dst_addr, + }; + + rtrs_addr_to_str(&path, str, sizeof(str)); mutex_lock(&sess->init_mutex); err = init_conns(sess); if (err) { - char str[NAME_MAX]; - int err; - struct rtrs_addr path = { - .src = &sess->s.src_addr, - .dst = &sess->s.dst_addr, - }; - - rtrs_addr_to_str(&path, str, sizeof(str)); rtrs_err(sess->clt, "init_conns() failed: err=%d path=%s [%s:%u]\n", err, str, sess->hca_name, sess->hca_port); goto out; } err = rtrs_send_sess_info(sess); if (err) { - char str[NAME_MAX]; - int err; - struct rtrs_addr path = { - .src = &sess->s.src_addr, - .dst = &sess->s.dst_addr, - }; - - rtrs_addr_to_str(&path, str, sizeof(str)); rtrs_err(sess->clt, "rtrs_send_sess_info() failed: err=%d path=%s [%s:%u]\n", err, str, sess->hca_name, sess->hca_port); goto out; -- 2.25.1