On 2021/4/6 16:43, Leon Romanovsky wrote: > On Tue, Apr 06, 2021 at 04:19:42PM +0800, Weihang Li wrote: >> From: Wenpeng Liang <liangwenpeng@xxxxxxxxxx> >> >> Space is not required between function name and '(', after '(', before ')', >> before ',' and between '*' and symbol name of a definition. >> >> Signed-off-by: Wenpeng Liang <liangwenpeng@xxxxxxxxxx> >> Signed-off-by: Weihang Li <liweihang@xxxxxxxxxx> >> --- >> drivers/infiniband/core/cache.c | 10 +++--- >> drivers/infiniband/core/cm.c | 31 ++++++++--------- >> drivers/infiniband/core/cma.c | 10 +++--- >> drivers/infiniband/core/device.c | 64 +++++++++++++++++------------------ >> drivers/infiniband/core/mad.c | 20 +++++------ >> drivers/infiniband/core/mad_rmpp.c | 10 +++--- >> drivers/infiniband/core/nldev.c | 2 +- >> drivers/infiniband/core/security.c | 12 +++---- >> drivers/infiniband/core/sysfs.c | 8 ++--- >> drivers/infiniband/core/user_mad.c | 6 ++-- >> drivers/infiniband/core/uverbs_cmd.c | 20 +++++------ >> drivers/infiniband/core/uverbs_main.c | 3 +- >> drivers/infiniband/core/uverbs_uapi.c | 16 ++++----- >> 13 files changed, 105 insertions(+), 107 deletions(-) >> >> diff --git a/drivers/infiniband/core/cache.c b/drivers/infiniband/core/cache.c >> index d779590..0b8c410 100644 >> --- a/drivers/infiniband/core/cache.c >> +++ b/drivers/infiniband/core/cache.c >> @@ -886,7 +886,7 @@ static void gid_table_release_one(struct ib_device *ib_dev) >> { >> u32 p; >> >> - rdma_for_each_port (ib_dev, p) { >> + rdma_for_each_port(ib_dev, p) { > > This space is an outcome of clang formatter. I would say that we are > fine that submitted patches will be with and without space. > > Thanks > I see, I will drop unnecessary changes about xx_for_each() and maybe something else. Thank you Weihang