On Thu, Mar 25, 2021 at 04:33:00PM +0100, Gioh Kim wrote:
> From: Gioh Kim <gi-oh.kim@xxxxxxxxxxxxxxx>
>
> Client prints only error value and it is not enough for debugging.
>
> 1. When client receives an error from server:
> the client does not only print the error value but also
> more information of server connection.
>
> 2. When client failes to send IO:
> the client gets an error from RDMA layer. It also
> print more information of server connection.
>
> Signed-off-by: Gioh Kim <gi-oh.kim@xxxxxxxxx>
> Signed-off-by: Jack Wang <jinpu.wang@xxxxxxxxx>
> drivers/infiniband/ulp/rtrs/rtrs-clt.c | 31 ++++++++++++++++++++++----
> 1 file changed, 27 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/infiniband/ulp/rtrs/rtrs-clt.c b/drivers/infiniband/ulp/rtrs/rtrs-clt.c
> index 1519191d7154..a41864ec853d 100644
> +++ b/drivers/infiniband/ulp/rtrs/rtrs-clt.c
> @@ -440,6 +440,11 @@ static void complete_rdma_req(struct rtrs_clt_io_req *req, int errno,
> req->in_use = false;
> req->con = NULL;
>
> + if (unlikely(errno)) {
> + rtrs_err_rl(con->c.sess, "IO request failed: error=%d path=%s [%s:%u]\n",
> + errno, kobject_name(&sess->kobj), sess->hca_name, sess->hca_port);
> + }
> +
> if (notify)
> req->conf(req->priv, errno);
> }
> @@ -1026,7 +1031,8 @@ static int rtrs_clt_write_req(struct rtrs_clt_io_req *req)
> req->usr_len + sizeof(*msg),
> imm);
> if (unlikely(ret)) {
> - rtrs_err(s, "Write request failed: %d\n", ret);
> + rtrs_err_rl(s, "Write request failed: error=%d path=%s [%s:%u]\n",
> + ret, kobject_name(&sess->kobj), sess->hca_name, sess->hca_port);
> if (sess->clt->mp_policy == MP_POLICY_MIN_INFLIGHT)
> atomic_dec(&sess->stats->inflight);
> if (req->sg_cnt)
> @@ -1144,7 +1150,8 @@ static int rtrs_clt_read_req(struct rtrs_clt_io_req *req)
> ret = rtrs_post_send_rdma(req->con, req, &sess->rbufs[buf_id],
> req->data_len, imm, wr);
> if (unlikely(ret)) {
> - rtrs_err(s, "Read request failed: %d\n", ret);
> + rtrs_err_rl(s, "Read request failed: error=%d path=%s [%s:%u]\n",
> + ret, kobject_name(&sess->kobj), sess->hca_name, sess->hca_port);
> if (sess->clt->mp_policy == MP_POLICY_MIN_INFLIGHT)
> atomic_dec(&sess->stats->inflight);
> req->need_inv = false;
> @@ -2465,12 +2472,28 @@ static int init_sess(struct rtrs_clt_sess *sess)
> mutex_lock(&sess->init_mutex);
> err = init_conns(sess);
> if (err) {
> - rtrs_err(sess->clt, "init_conns(), err: %d\n", err);
> + char str[NAME_MAX];
> + int err;
> + struct rtrs_addr path = {
> + .src = &sess->s.src_addr,
> + .dst = &sess->s.dst_addr,
> + };
> + rtrs_addr_to_str(&path, str, sizeof(str));
Coding style is to have new lines after variable blocks.
Jason
