On 3/30/21 00:39, Gioh Kim wrote: > From: Gioh Kim <gi-oh.kim@xxxxxxxxxxxxxxx> > > They are defined with the same value and similar meaning, let's remove > one of them, then we can remove {WAIT,NOWAIT}. > > Also change the type of 'wait' from 'int' to 'enum wait_type' to make > it clear. > > Cc: Jason Gunthorpe <jgg@xxxxxxxxxxxx> > Cc: Leon Romanovsky <leonro@xxxxxxxxxx> > Cc: linux-rdma@xxxxxxxxxxxxxxx > Signed-off-by: Guoqing Jiang <guoqing.jiang@xxxxxxxxx> > Reviewed-by: Md Haris Iqbal <haris.iqbal@xxxxxxxxx> > Signed-off-by: Gioh Kim <gi-oh.kim@xxxxxxxxx> > Signed-off-by: Jack Wang <jinpu.wang@xxxxxxxxx> It makes sense to not duplicate the enums, looks good. Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@xxxxxxx>