On Thu, Mar 25, 2021 at 5:12 PM Leon Romanovsky <leonro@xxxxxxxxxx> wrote:
>
> On Thu, Mar 25, 2021 at 04:29:00PM +0100, Gioh Kim wrote:
> > From: Gioh Kim <gi-oh.kim@xxxxxxxxxxxxxxx>
> >
> > They are defined with the same value and similar meaning, let's remove
> > one of them, then we can remove {WAIT,NOWAIT}.
> >
> > Also change the type of 'wait' from 'int' to 'enum wait_type' to make
> > it clear.
> >
> > Cc: Jason Gunthorpe <jgg@xxxxxxxxxxxx>
> > Cc: Leon Romanovsky <leonro@xxxxxxxxxx>
> > Cc: linux-rdma@xxxxxxxxxxxxxxx
> > Signed-off-by: Guoqing Jiang <guoqing.jiang@xxxxxxxxx>
> > Reviewed-by: Md Haris Iqbal <haris.iqbal@xxxxxxxxx>
> > Signed-off-by: Gioh Kim <gi-oh.kim@xxxxxxxxx>
> > Signed-off-by: Jack Wang <jinpu.wang@xxxxxxxxx>
> > ---
> > drivers/block/rnbd/rnbd-clt.c | 42 +++++++++++---------------
> > drivers/infiniband/ulp/rtrs/rtrs-clt.c | 4 +--
> > drivers/infiniband/ulp/rtrs/rtrs.h | 6 ++--
> > 3 files changed, 22 insertions(+), 30 deletions(-)
>
> <...>
>
> > @@ -535,7 +527,7 @@ static void msg_open_conf(struct work_struct *work)
> > * If server thinks its fine, but we fail to process
> > * then be nice and send a close to server.
> > */
> > - (void)send_msg_close(dev, device_id, NO_WAIT);
> > + (void)send_msg_close(dev, device_id, RTRS_PERMIT_NOWAIT);
>
> This (void) casting is not needed.
I will fix them.
Thank you.
>
> Thanks
