On Mon, Mar 22, 2021 at 03:11:33PM +0200, Gal Pressman wrote: > > On 22/03/2021 15:01, Jason Gunthorpe wrote: > > On Tue, Mar 16, 2021 at 03:24:16PM +0200, Gal Pressman wrote: > >> The strlcpy function doesn't limit the source length, use the preferred > >> strscpy function instead. > > > > Why do we need to limit the source length here? Either this is a bug > > because the source string is no NULL terminated or it is OK as is? > > It's not a bug as is, but it addresses checkpatch's warning: > WARNING: Prefer strscpy over strlcpy - see: https://lore.kernel.org/r/CAHk-=wgfRnXz0W3D37d01q3JFkr_i_uTL=V6A6G1oUZcprmknw@xxxxxxxxxxxxxx/ Okay.. but why is it so weird: strscpy(hinf->kernel_ver_str, utsname()->version, min(sizeof(hinf->kernel_ver_str), sizeof(utsname()->version))); ? utsname()->version is null terminated, yes? Why does it need to be min'd? Jason
