On 3/21/2021 4:56 AM, Leon Romanovsky wrote:
On Sat, Mar 20, 2021 at 12:39:46PM -0400, Dennis Dalessandro wrote:
On 3/19/2021 6:57 PM, Rimmer, Todd wrote:
[Wan, Kaike] Incorrect. The rv module works with hfi1.
<...>
We have removed all GPU specific code from the upstream submission, but used both the "alignment holes" and the "reserved"
mechanisms to hold places for GPU specific fields which can't be upstreamed.
This problem extends to other drivers as well. I'm also interested in advice
on the situation. I don't particularly like this either, but we need a way
to accomplish the goal. We owe it to users to be flexible. Please offer
suggestions.
Sorry to interrupt, but it seems that solution was said here [1].
It wasn't said directly, but between the lines it means that you need
two things:
1. Upstream everything.
Completely agree. However the GPU code from nvidia is not upstream. I
don't see that issue getting resolved in this code review. Let's move on.
2. Find another vendor that jumps on this RV bandwagon.
That's not a valid argument. Clearly this works over multiple vendors HW.
We should be trying to get things upstream, not putting up walls when
people want to submit new drivers. Calling code "garbage" [1] is not
productive.
> [1]
https://lore.kernel.org/linux-rdma/20210319230644.GI2356281@xxxxxxxxxx
-Denny
