Hi Selvin, I love your patch! Perhaps something to improve: [auto build test WARNING on rdma/for-next] [also build test WARNING on v5.12-rc3 next-20210316] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Selvin-Xavier/RDMA-bnxt_re-Move-device-to-error-state-upon-device-crash/20210317-131222 base: https://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma.git for-next config: powerpc-allyesconfig (attached as .config) compiler: powerpc64-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/3e89320b3476467ccb141c6b5e46c1615f010b66 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Selvin-Xavier/RDMA-bnxt_re-Move-device-to-error-state-upon-device-crash/20210317-131222 git checkout 3e89320b3476467ccb141c6b5e46c1615f010b66 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=powerpc If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@xxxxxxxxx> All warnings (new ones prefixed by >>): drivers/infiniband/hw/bnxt_re/main.c: In function 'bnxt_re_stop': >> drivers/infiniband/hw/bnxt_re/main.c:226:26: warning: variable 'rcfw' set but not used [-Wunused-but-set-variable] 226 | struct bnxt_qplib_rcfw *rcfw; | ^~~~ vim +/rcfw +226 drivers/infiniband/hw/bnxt_re/main.c 221 222 /* for handling bnxt_en callbacks later */ 223 static void bnxt_re_stop(void *p) 224 { 225 struct bnxt_re_dev *rdev = p; > 226 struct bnxt_qplib_rcfw *rcfw; 227 struct bnxt *bp; 228 229 if (!rdev) 230 return; 231 ASSERT_RTNL(); 232 233 /* L2 driver invokes this callback during device error/crash or device 234 * reset. Current RoCE driver doesn't recover the device in case of 235 * error. Handle the error by dispatching fatal events to all qps 236 * ie. by calling bnxt_re_dev_stop and release the MSIx vectors as 237 * L2 driver want to modify the MSIx table. 238 */ 239 bp = netdev_priv(rdev->netdev); 240 rcfw = &rdev->rcfw; 241 242 ibdev_info(&rdev->ibdev, "Handle device stop call from L2 driver"); 243 /* Check the current device state from L2 structure and move the 244 * device to detached state if FW_FATAL_COND is set. 245 * This prevents more commands to HW during clean-up, 246 * in case the device is already in error. 247 */ 248 if (test_bit(BNXT_STATE_FW_FATAL_COND, &bp->state)) 249 set_bit(ERR_DEVICE_DETACHED, &rdev->rcfw.cmdq.flags); 250 251 bnxt_re_dev_stop(rdev); 252 bnxt_re_stop_irq(rdev); 253 /* Move the device states to detached and avoid sending any more 254 * commands to HW 255 */ 256 set_bit(BNXT_RE_FLAG_ERR_DEVICE_DETACHED, &rdev->flags); 257 set_bit(ERR_DEVICE_DETACHED, &rdev->rcfw.cmdq.flags); 258 } 259 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx
Attachment:
.config.gz
Description: application/gzip
