On Thu, Mar 04, 2021 at 02:45:16PM +0200, Leon Romanovsky wrote: > -static int > -mlx5_ib_create_pf_eq(struct mlx5_ib_dev *dev, struct mlx5_ib_pf_eq *eq) > +int mlx5r_odp_create_eq(struct mlx5_ib_dev *dev, struct mlx5_ib_pf_eq *eq) > { > struct mlx5_eq_param param = {}; > - int err; > + int err = 0; > > + if (eq->core) > + return 0; > + > + mutex_lock(&dev->odp_eq_mutex); The above if is locked wrong. Jason