On Wed, 2021-03-03 at 09:54 +0200, Roi Dayan wrote:
>
>
> On 2021-03-03 4:40 AM, angkery wrote:
> > From: Junlin Yang <yangjunlin@xxxxxxxxxx>
> >
> > It is allocated with kvzalloc(), the corresponding release function
> > should not be kfree(), use kvfree() instead.
> >
> > Generated by: scripts/coccinelle/api/kfree_mismatch.cocci
> >
> > Signed-off-by: Junlin Yang <yangjunlin@xxxxxxxxxx>
> > ---
> > drivers/net/ethernet/mellanox/mlx5/core/esw/indir_table.c | 10
> > +++++-----
> > 1 file changed, 5 insertions(+), 5 deletions(-)
> >
> > diff --git
> > a/drivers/net/ethernet/mellanox/mlx5/core/esw/indir_table.c
> > b/drivers/net/ethernet/mellanox/mlx5/core/esw/indir_table.c
> > index 6f6772b..3da7bec 100644
> > --- a/drivers/net/ethernet/mellanox/mlx5/core/esw/indir_table.c
> > +++ b/drivers/net/ethernet/mellanox/mlx5/core/esw/indir_table.c
> > @@ -248,7 +248,7 @@ static int mlx5_esw_indir_table_rule_get(struct
> > mlx5_eswitch *esw,
> > err_ethertype:
> > kfree(rule);
> > out:
> > - kfree(rule_spec);
> > + kvfree(rule_spec);
> > return err;
> > }
> >
> > @@ -328,7 +328,7 @@ static int
> > mlx5_create_indir_recirc_group(struct mlx5_eswitch *esw,
> > e->recirc_cnt = 0;
> >
> > out:
> > - kfree(in);
> > + kvfree(in);
> > return err;
> > }
> >
> > @@ -347,7 +347,7 @@ static int mlx5_create_indir_fwd_group(struct
> > mlx5_eswitch *esw,
> >
> > spec = kvzalloc(sizeof(*spec), GFP_KERNEL);
> > if (!spec) {
> > - kfree(in);
> > + kvfree(in);
> > return -ENOMEM;
> > }
> >
> > @@ -371,8 +371,8 @@ static int mlx5_create_indir_fwd_group(struct
> > mlx5_eswitch *esw,
> > }
> >
> > err_out:
> > - kfree(spec);
> > - kfree(in);
> > + kvfree(spec);
> > + kvfree(in);
> > return err;
> > }
> >
> >
>
> thanks!
>
> Reviewed-by: Roi Dayan <roid@xxxxxxxxxx>
>
applied to net-next-mlx5
