On Fri, Feb 26, 2021 at 06:02:39PM -0600, Bob Pearson wrote: > On 2/26/21 5:33 PM, Jason Gunthorpe wrote: > > On Fri, Feb 26, 2021 at 05:28:41PM -0600, Bob Pearson wrote: > >> Just a reminder. rxe in for-next is broken until this gets done. > >> thanks > > > > I was expecting you to resend it? There seemed to be some changes > > needed > > > > https://patchwork.kernel.org/project/linux-rdma/patch/20210214222630.3901-1-rpearson@xxxxxxx/ > > > > Jason > > > OK. I see. I agreed to that complaint when the kfree was the only thing in the if {} but now I have to call ib_device_put() *only* in the error case not if there wasn't an error. So no reason to not put the kfree_skb() in there too and avoid passing a NULL pointer. It should stay the way it is. First, I posted a diff which makes this if() redundant. Second, the if () before kfree() is checked by coccinelle and your "should stay the way it is" will be marked as failure in many CIs, including ours. Thanks > > bob
