On 2/22/21 7:58 AM, Jason Gunthorpe wrote: > On Mon, Feb 22, 2021 at 03:00:03PM +0200, Leon Romanovsky wrote: >> On Mon, Feb 22, 2021 at 10:39:20AM +0800, Zhu Yanjun wrote: >>> On Sun, Feb 21, 2021 at 2:49 PM Leon Romanovsky <leon@xxxxxxxxxx> wrote: >>>> >>>> On Fri, Feb 19, 2021 at 06:32:26PM -0500, Julian Braha wrote: >>>>> commit 6e61907779ba99af785f5b2397a84077c289888a >>>>> Author: Julian Braha <julianbraha@xxxxxxxxx> >>>>> Date: Fri Feb 19 18:20:57 2021 -0500 >>>>> >>>>> drivers: infiniband: sw: rxe: fix kconfig dependency on CRYPTO >>>>> >>>>> When RDMA_RXE is enabled and CRYPTO is disabled, >>>>> Kbuild gives the following warning: >>>>> >>>>> WARNING: unmet direct dependencies detected for CRYPTO_CRC32 >>>>> Depends on [n]: CRYPTO [=n] >>>>> Selected by [y]: >>>>> - RDMA_RXE [=y] && (INFINIBAND_USER_ACCESS [=y] || !INFINIBAND_USER_ACCESS [=y]) && INET [=y] && PCI [=y] && INFINIBAND [=y] && INFINIBAND_VIRT_DMA [=y] >>>>> >>>>> This is because RDMA_RXE selects CRYPTO_CRC32, >>>>> without depending on or selecting CRYPTO, despite that config option >>>>> being subordinate to CRYPTO. >>>>> >>>>> Signed-off-by: Julian Braha <julianbraha@xxxxxxxxx> >>>> >>>> Please use git sent-email to send patches and please fix crypto Kconfig >>>> to enable CRYPTO if CRYPTO_* selected. >>>> >>>> It is a little bit awkward to request all users of CRYPTO_* to request >>>> select CRYPTO too. >>> >>> The same issue and similar patch is in this link: >>> >>> https://patchwork.kernel.org/project/linux-rdma/patch/20200915101559.33292-1-fazilyildiran@xxxxxxxxx/#23615747 >> >> So what prevents us from fixing CRYPTO Kconfig? > > Yes, I would like to see someone deal with this properly, either every > place doing select CRYPTO_XX needs fixing or something needs to be > done in the crypto layer. > > I have no idea about kconfig to give advice, I've added Arnd since he > always seems to know :) I will Ack the original patch in this thread. How many Mellanox drivers are you concerned about? You don't have to fix any other drivers that have a similar issue. -- ~Randy
