Re: [PATCH] ppp: Remove redundant BUG_ON() check in ppp_pernet

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Xu Wang <vulab@xxxxxxxxxxx>, paulus@xxxxxxxxx
Subject: Re: [PATCH] ppp: Remove redundant BUG_ON() check in ppp_pernet
From: Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx>
Date: Tue, 24 Dec 2019 14:42:12 +0300
Cc: davem@xxxxxxxxxxxxx, linux-ppp@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to: <1577180224-16405-1-git-send-email-vulab@iscas.ac.cn>
Organization: Cogent Embedded
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1

Hello!

On 12/24/2019 12:37 PM, Xu Wang wrote:

> Passing NULL to ppp_pernet causes a crash via BUG_ON.
> Dereferencing net in net_generici() also has the same effect.

   s/generici/generic/. :-)

> This patch removes the redundant BUG_ON check on the same parameter.
> 
> Signed-off-by: Xu Wang <vulab@xxxxxxxxxxx>
[...]

MBR, Sergei

References:
- [PATCH] ppp: Remove redundant BUG_ON() check in ppp_pernet
  - From: Xu Wang

Prev by Date: [PATCH] ppp: Remove redundant BUG_ON() check in ppp_pernet
Next by Date: [PATCH v2] ppp: Remove redundant BUG_ON() check in ppp_pernet
Previous by thread: [PATCH] ppp: Remove redundant BUG_ON() check in ppp_pernet
Next by thread: Re: [PATCH] ppp: Remove redundant BUG_ON() check in ppp_pernet
Index(es):
- Date
- Thread

[Index of Archives] [Linux Audio Users] [Linux for Hams] [Kernel Newbies] [Security] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Samba] [Video 4 Linux] [Fedora Users]

Powered by Linux