On Tue, Oct 31, 2017 at 06:25:37PM +0800, gfree.wind@xxxxxxxxxxx wrote: > From: Gao Feng <gfree.wind@xxxxxxxxxxx> > > The mutex_destroy only makes sense when enable DEBUG_MUTEX. For the > good readbility, it's better to invoke it in exit func when the init > func invokes mutex_init. > > Signed-off-by: Gao Feng <gfree.wind@xxxxxxxxxxx> > --- > drivers/net/ppp/ppp_generic.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/ppp/ppp_generic.c b/drivers/net/ppp/ppp_generic.c > index af7f93e..4489133 100644 > --- a/drivers/net/ppp/ppp_generic.c > +++ b/drivers/net/ppp/ppp_generic.c > @@ -960,6 +960,7 @@ static __net_exit void ppp_exit_net(struct net *net) > unregister_netdevice_many(&list); > rtnl_unlock(); > > + mutex_destroy(&pn->all_ppp_mutex); > idr_destroy(&pn->units_idr); > } > Acked-by: Guillaume Nault <g.nault@xxxxxxxxxxxx> Thanks! -- To unsubscribe from this list: send the line "unsubscribe linux-ppp" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
