Re: [PATCH] ppp: Fix false xmit recursion detect with two ppp devices

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


From: gfree.wind@xxxxxxxxxxx
Date: Mon, 17 Jul 2017 18:34:42 +0800

> From: Gao Feng <gfree.wind@xxxxxxxxxxx>
> The global percpu variable ppp_xmit_recursion is used to detect the ppp
> xmit recursion to avoid the deadlock, which is caused by one CPU tries to
> lock the xmit lock twice. But it would report false recursion when one CPU
> wants to send the skb from two different PPP devices, like one L2TP on the
> PPPoE. It is a normal case actually.
> Now use one percpu member of struct ppp instead of the gloable variable to
> detect the xmit recursion of one ppp device.
> Fixes: 55454a565836 ("ppp: avoid dealock on recursive xmit")
> Signed-off-by: Gao Feng <gfree.wind@xxxxxxxxxxx>
> Signed-off-by: Liu Jianying <jianying.liu@xxxxxxxxxx>

Indeed, for a per-ppp lock recursion check we need a per-ppp counter.

Applied, thanks!
To unsubscribe from this list: send the line "unsubscribe linux-ppp" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at

[Index of Archives]     [Linux Audio Users]     [Linux for Hams]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Fedora Users]

  Powered by Linux